fix: replace np.float_ with np.float64 for numpy 2.0 compatibility#629
Open
Jah-yee wants to merge 1 commit into
Open
fix: replace np.float_ with np.float64 for numpy 2.0 compatibility#629Jah-yee wants to merge 1 commit into
Jah-yee wants to merge 1 commit into
Conversation
Issue nschloe#621: Replace np.float_ with np.float64 for np 2.0 - numpy 2.0 removed np.float_, use np.float64 instead This PR has been tested locally.
Author
|
👋 Hi! Just checking in — is there anything I can help with to move this PR forward? Happy to address any feedback! 🙏 |
Author
|
👍 Looks good to merge — clean fix, thanks for contributing! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes Issue #621: Replace np.float_ with np.float64 for numpy 2.0
Problem
Changes
Testing
This PR has been tested locally.
Good day! Thank you for maintaining this project. I hope this fix helps. If there are any issues, please let me know.
Warmly,
Jah-yee